Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-7605 Deprecate procedure syntax #3076

Merged
merged 1 commit into from Oct 29, 2013

Conversation

@soc
Copy link
Member

@soc soc commented Oct 23, 2013

This commit covers three cases:

  • constructor definitions (def this {...})
  • concrete method definitions (def foo {...})
  • abstract method declarations (def foo)

The deprecation is currently hidden behind -Xfuture pending IDE support
for migrating users from procedures to methods.

This commit covers three cases:
- constructor definitions      (def this {...})
- concrete method definitions  (def foo {...})
- abstract method declarations (def foo)

The deprecation is currently hidden behind -Xfuture pending IDE support
for migrating users from procedures to methods.
@soc
Copy link
Member Author

@soc soc commented Oct 23, 2013

Review by @odersky / @jsuereth, please.

@JamesIry
Copy link
Contributor

@JamesIry JamesIry commented Oct 25, 2013

Would it make sense to remove the use of procedure syntax in the compiler and library in the same PR (separate commit) or is the job too big for one pass?

@soc
Copy link
Member Author

@soc soc commented Oct 25, 2013

@JamesIry My plan was to first do the minimal thing to get the warning so that I can start looking into IDE support.
With IDE support working, I would have migrated our code. In some sense, it's eating our own dog food. If the IDE handles all migration cases from the standard library fine, I'd be optimistic that it is ready for prime-time.

So, yes, I could do it now manually, but I'd prefer using the IDE to verify that things work as expected.

@JamesIry
Copy link
Contributor

@JamesIry JamesIry commented Oct 25, 2013

LGTM, but would like some comment from the reviewers or @adriaanm

@ghost ghost assigned adriaanm Oct 25, 2013
@adriaanm
Copy link
Member

@adriaanm adriaanm commented Oct 25, 2013

LGTM2 -- thanks, Simon!

@adriaanm
Copy link
Member

@adriaanm adriaanm commented Oct 25, 2013

In this area, we should also deprecate implicit definitions without return type. They cause much more confusion (and supposed type checker slowdown) than it's worth (not to mention binary/behaviorally incompatible changes due to changes in type inference...)

@soc
Copy link
Member Author

@soc soc commented Oct 29, 2013

@adriaanm Is this good to go or was your comment about adding a deprecation for implicit defs targeted at this commit?

@adriaanm
Copy link
Member

@adriaanm adriaanm commented Oct 29, 2013

this is good to go, just meant to say "while you're at it -- here's some more stuff I think we should deprecate"

@adriaanm
Copy link
Member

@adriaanm adriaanm commented Oct 29, 2013

Thanks!

JamesIry added a commit that referenced this pull request Oct 29, 2013
@JamesIry JamesIry merged commit 9b8d108 into scala:master Oct 29, 2013
1 check passed
1 check passed
@scala-jenkins
default pr-scala Took 77 min.
Details
eed3si9n added a commit to eed3si9n/scala that referenced this pull request Feb 14, 2018
Ref scala/bug#7605

scala#3076 deprecated the procedure syntax, but only under -Xfuture flag. This deprecates it without it, and drops it under -Xsource:2.14.
eed3si9n added a commit to eed3si9n/scala that referenced this pull request Mar 4, 2018
Ref scala/bug#7605

scala#3076 deprecated the procedure syntax, but only under -Xfuture flag. This deprecates it without it, and drops it under -Xsource:2.14.
adriaanm added a commit to eed3si9n/scala that referenced this pull request Apr 10, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.

See scala/bug#7605
adriaanm added a commit to eed3si9n/scala that referenced this pull request Apr 10, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.

See scala/bug#7605
adriaanm added a commit to eed3si9n/scala that referenced this pull request Apr 10, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.

See scala/bug#7605
adriaanm added a commit to eed3si9n/scala that referenced this pull request Apr 11, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.

See scala/bug#7605
eed3si9n added a commit to eed3si9n/scala that referenced this pull request Apr 24, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.

See scala/bug#7605
eed3si9n added a commit to eed3si9n/scala that referenced this pull request Apr 25, 2018
Procedure syntax was deprecated under -Xfuture flag in scala#3076.
This deprecates it unconditionally, and drops it under -Xsource:2.14.
See scala/bug#7605

To update the tests, this drops procedure syntax from test/ using ScalaFix

```
$ coursier launch ch.epfl.scala:scalafix-cli_2.12.3:0.5.3 -- -r ProcedureSyntax test
$ coursier launch ch.epfl.scala:scalafix-cli_2.12.4:0.5.10 -- -r ExplicitUnit test
```
@joan38 joan38 mentioned this pull request May 4, 2018
0 of 3 tasks complete
Jentsch added a commit to Jentsch/scala-graph that referenced this pull request Jul 9, 2019
The procedure syntax was removed in scala/scala#3076

Scalac will now complain about the procedure syntax

All changes where made by scalafix
Jentsch added a commit to Jentsch/scala-graph that referenced this pull request Jul 9, 2019
The procedure syntax was removed in scala/scala#3076

Scalac will now complain about the procedure syntax

All changes source where made by scalafix and scalafmt
Jentsch added a commit to Jentsch/scala-graph that referenced this pull request Jul 9, 2019
The procedure syntax was deprecated in scala/scala#3076

The new scalac options trigger now warnings when using the procedure syntax.

All changes source where made by scalafix and scalafmt.
Jentsch added a commit to Jentsch/scala-graph that referenced this pull request Jul 9, 2019
The procedure syntax was deprecated in scala/scala#3076

The new scalac options trigger now warnings when using the procedure syntax.

All changes, aside the sbt files, were made by scalafix and scalafmt.
Jentsch added a commit to Jentsch/scala-graph that referenced this pull request Jul 11, 2019
The procedure syntax was deprecated in scala/scala#3076

The new scalac options trigger now warnings when using the procedure syntax.

All changes, aside the sbt files, were made by scalafix and scalafmt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants