New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-7618 Remove octal number literals #3240

Merged
merged 1 commit into from Dec 13, 2013

Conversation

Projects
None yet
2 participants
@soc
Copy link
Member

soc commented Dec 9, 2013

This also fixes a spurious detection of octal literals in floating
point literals: Literals like 01.23 are neither deprecated nor planned
for removal.

while (digit2int(ch, base1) >= 0) {
putChar(ch)
nextChar()
notSingleZero = true

This comment has been minimized.

@adriaanm

adriaanm Dec 9, 2013

Member

Could you add a comment on why this flag can soundly be computed this way? The logic is quite spread out, or it's at least not obvious to me.

This comment has been minimized.

@soc

soc Dec 9, 2013

Author Member

Will do.

SI-7618 Remove octal number literals
This also fixes a spurious detection of octal literals in floating
point literals: Literals like 01.23 are neither deprecated nor planned
for removal.
@soc

This comment has been minimized.

Copy link
Member Author

soc commented Dec 9, 2013

Review by @adriaanm, please! I added comments. Hopefully things are a bit more clear now.

@ghost ghost assigned adriaanm Dec 13, 2013

@adriaanm

This comment has been minimized.

Copy link
Member

adriaanm commented Dec 13, 2013

LGTM -- thanks!

adriaanm added a commit that referenced this pull request Dec 13, 2013

Merge pull request #3240 from soc/SI-7618
SI-7618 Remove octal number literals

@adriaanm adriaanm merged commit 43eb7a9 into scala:master Dec 13, 2013

1 check passed

default pr-scala Took 69 min.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment