SI-8330: Mismatch in stack heights #3580

Merged
merged 1 commit into from Feb 24, 2014

Projects

None yet

2 participants

@gkossakowski
Member

The SI-8233 / 9506d52 missed one case when we need to DROP a null from
a stack: when unboxed Unit is an expected type. If we forgot to do that
in a context where two branches were involved we could end up with
unbalanced stack sizes.

Let's fix that omission and a test covering that specific case to the
original test for SI-8233.

Fixes SI-8330.

@gkossakowski gkossakowski SI-8330: Mismatch in stack heights
The SI-8233 / 9506d52 missed one case when we need to DROP a null from
a stack: when unboxed Unit is an expected type. If we forgot to do that
in a context where two branches were involved we could end up with
unbalanced stack sizes.

Let's fix that omission and a test covering that specific case to the
original test for SI-8233.

Fixes SI-8330.
7def1a9
@gkossakowski
Member

Review by @adriaanm

//cc @retronym

@adriaanm
Member

LGTM

@gkossakowski gkossakowski merged commit 7c709e1 into scala:master Feb 24, 2014

1 check passed

default pr-scala Took 68 min.
Details
@gkossakowski gkossakowski deleted the gkossakowski:issue/SI-8330 branch Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment