Revert "SI-8315 Better debugging facility for ICode" #3586

Merged
merged 1 commit into from Feb 26, 2014

Projects

None yet

2 participants

@adriaanm
The Scala Programming Language member

This reverts commit 0561dd0.

When the windows nightly broke, git bisect pointed its unwavering finger at this poor soul.

Build passes again after the revert: https://scala-webapps.epfl.ch/jenkins/job/scala-checkin-manual-windows/39/console

I have no idea why, but the machines don't lie (and I don't have time right now to dig deeper).
Ok, if I had to guess, I'd say the longer filenames for the .icode files confused windows somehow.

@adriaanm adriaanm Selectively revert "SI-8315 Better debugging facility for ICode"
This reverts commit 0561dd0,
because appending the phase name to the icode filename breaks
the windows build. Only doing it under -Ydebug.
52d60e6
@adriaanm
The Scala Programming Language member

review by @gkossakowski

@adriaanm
The Scala Programming Language member
@gkossakowski
The Scala Programming Language member

LGTM

I'm sad to let 0561dd0 go because it helped me in my recent debugging session of our beloved (old) optimizer. However, I agree that machines do not lie. To be looked at later in 2.11.x cycle.

@adriaanm adriaanm added the reviewed label Feb 26, 2014
@adriaanm
The Scala Programming Language member

The old behaviour is still available under -Ydebug. Whyyyy debug?

@adriaanm adriaanm added tested and removed needs-attention labels Feb 26, 2014
@gkossakowski gkossakowski merged commit 8b95e11 into scala:master Feb 26, 2014

1 check passed

Details default pr-scala Took 57 min.
@adriaanm adriaanm deleted the adriaanm:windows-opt-fail-revert branch Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment