New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-8251 Remove ListBuffer.readOnly as deprecated #4140

Merged
merged 1 commit into from Nov 21, 2014

Conversation

Projects
None yet
5 participants
@som-snytt
Contributor

som-snytt commented Nov 21, 2014

Complete the story arc.

@scala-jenkins scala-jenkins added this to the 2.12.0-M1 milestone Nov 21, 2014

@gkossakowski

This comment has been minimized.

Show comment
Hide comment
@gkossakowski
Member

gkossakowski commented Nov 21, 2014

LGTM

gkossakowski added a commit that referenced this pull request Nov 21, 2014

Merge pull request #4140 from som-snytt/issue/8251
SI-8251 Remove ListBuffer.readOnly as deprecated

@gkossakowski gkossakowski merged commit 571616c into scala:2.12.x Nov 21, 2014

1 check passed

default pr-scala Took 63 min.
Details

@som-snytt som-snytt deleted the som-snytt:issue/8251 branch Feb 9, 2015

adriaanm added a commit to adriaanm/sbt that referenced this pull request Jul 9, 2015

Do not use `ListBuffer#readOnly`
It's dangerous, deprecated, and was removed in 2.12.0-M1.
See scala/scala#4140.

`ListBuffer#toList` has equivalent performance,
except it actually returns an immutable copy(-on-write).
@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jul 9, 2015

Member

This removal is technically in violation of the 2.11/2.12 source compatibility policy.

OTOH, the method is noxious.

Member

SethTisue commented Jul 9, 2015

This removal is technically in violation of the 2.11/2.12 source compatibility policy.

OTOH, the method is noxious.

adriaanm added a commit to adriaanm/sbt that referenced this pull request Jul 10, 2015

Do not use `ListBuffer#readOnly`
It's dangerous, deprecated, and was removed in 2.12.0-M1.
See scala/scala#4140.

`ListBuffer#toList` has equivalent performance,
except it actually returns an immutable copy(-on-write).

eed3si9n pushed a commit to sbt/util that referenced this pull request Aug 20, 2015

Do not use `ListBuffer#readOnly`
It's dangerous, deprecated, and was removed in 2.12.0-M1.
See scala/scala#4140.

`ListBuffer#toList` has equivalent performance,
except it actually returns an immutable copy(-on-write).

@adriaanm adriaanm added the 2.12 label Oct 29, 2016

dwijnand pushed a commit to dwijnand/sbt-lm that referenced this pull request Jun 26, 2017

Do not use `ListBuffer#readOnly`
It's dangerous, deprecated, and was removed in 2.12.0-M1.
See scala/scala#4140.

`ListBuffer#toList` has equivalent performance,
except it actually returns an immutable copy(-on-write).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment