Add unit tests for Tseitin CNF conversion and implement missing equals method for Sym.
#4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbasler
force-pushed
the
topic/patmat-unit-tests-rebased
branch
2 times, most recently
from
52fba08
to
f84d3ea
Compare
|
Thanks! Could you split up the commit into the bugfix for the earlier PR (equals method) and the test? Why is the solver code duplicated in the test? Can we refactor the actual solver to make it testable directly? |
We compare the results using the Tseitin transformation with the results of a
conversion via expansion of the formula (using distributive laws), e.g.,
```
+-------+
|Formula|
+---+---+
|
+-----------+-----------+
| |
v v
+---------+ +-------+
|Expansion| |Tseitin|
+----+----+ +---+---+
| +-----+ |
+------->| =?= |<-------+
+-----+
```
both methods should deliver the same results (i.e., models).
gbasler
force-pushed
the
topic/patmat-unit-tests-rebased
branch
from
f84d3ea
to
5c296a4
Compare
|
I've split the commit into two parts. The current solver implementation is coupled with it's usage, I used a suggestion by @retronym to decouple the code. I don't see a better way right now since the traits are otherwise not accessible. |
|
LGTM, thanks for splitting them up. I'm going to merge this so we can get the improvement into 2.11.5 |
adriaanm
added a commit
that referenced
this pull request
Jan 2, 2015
Add unit tests for Tseitin CNF conversion and implement missing `equals` method for `Sym`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #4078.
The tests already paid off: figured out that I forgot to add
equals(shame on me)...Review by @adriaanm