New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -YclasspathImpl:flat by default #5057

Merged
merged 2 commits into from Mar 23, 2016

Conversation

Projects
None yet
6 participants
@lrytz
Member

lrytz commented Mar 22, 2016

No description provided.

lrytz added some commits Mar 22, 2016

Enable flat classpath by default
Implements VirtualDirectoryFlatClassPath, which is required for the
presentation compiler created for the repl's tab-completion.

Various minor cleanups in the flat classpath implementation.
Support :require when using the flat classpath representation.
:require was re-incarnated in #4051,
it seems to be used by the spark repl. This commit makes it work when
using the flat classpath representation.

@scala-jenkins scala-jenkins added this to the 2.12.0-M5 milestone Mar 22, 2016

@lrytz

This comment has been minimized.

Show comment
Hide comment
@lrytz

lrytz Mar 22, 2016

Member

review by @retronym

Member

lrytz commented Mar 22, 2016

review by @retronym

@retronym

This comment has been minimized.

Show comment
Hide comment
@retronym

retronym Mar 22, 2016

Member

LGTM

Tricky stuff. Hopefully we'll shed some complexity with the next steps to remove the recursive implementation, and after that using NIO.

Member

retronym commented Mar 22, 2016

LGTM

Tricky stuff. Hopefully we'll shed some complexity with the next steps to remove the recursive implementation, and after that using NIO.

@adriaanm adriaanm modified the milestones: 2.12.0-M4, 2.12.0-M5 Mar 22, 2016

@lrytz

This comment has been minimized.

Show comment
Hide comment
@lrytz

lrytz Mar 23, 2016

Member

Indeed, if we were to keep the recursive implementation this patch would come with more abstractions and less casting around.

Member

lrytz commented Mar 23, 2016

Indeed, if we were to keep the recursive implementation this patch would come with more abstractions and less casting around.

@lrytz lrytz merged commit 952da60 into scala:2.12.x Mar 23, 2016

6 checks passed

cla @lrytz signed the Scala CLA. Thanks!
Details
combined All previous commits successful.
integrate-ide [1376] SUCCESS. Took 3 s.
Details
validate-main [1601] SUCCESS. Took 107 min.
Details
validate-publish-core [1578] SUCCESS. Took 5 min.
Details
validate-test [1360] SUCCESS. Took 95 min.
Details
@soc

This comment has been minimized.

Show comment
Hide comment
@soc

soc Mar 23, 2016

Member

Yay! Thanks, @lrytz!

Member

soc commented Mar 23, 2016

Yay! Thanks, @lrytz!

@lrytz

This comment has been minimized.

Show comment
Hide comment
@lrytz

lrytz Mar 24, 2016

Member

community build status is being discussed here: scala/scala-dev#108 (looks good overall, there don't seem to be any issues related to this PR)

Member

lrytz commented Mar 24, 2016

community build status is being discussed here: scala/scala-dev#108 (looks good overall, there don't seem to be any issues related to this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment