upgrade to scala-xml 1.0.6 #5410

Merged
merged 1 commit into from Oct 31, 2016

Projects

None yet

5 participants

@SethTisue
Member
SethTisue commented Sep 20, 2016 edited

just because in general we want to ship the latest versions of the
modules, and some desirable-looking fixes went into 1.0.6

let's at least see if Jenkins passes

1.0.6 release notes: https://github.com/scala/scala-xml/releases/tag/v1.0.6

@SethTisue SethTisue upgrade to scala-xml 1.0.6
just because in general we want to ship the latest versions of the
modules, and some desirable-looking fixes went into 1.0.6
74d61dc
@scala-jenkins scala-jenkins added this to the 2.12.1 milestone Sep 20, 2016
@SethTisue
Member
SethTisue commented Sep 20, 2016 edited

probably not to be merged right away? it would be nice to have some reports from the field that the new version is usable

at the time this is merged, we should also bump scala-xml-version in the 2.12 community build

@lrytz
Member
lrytz commented Sep 30, 2016

How about running a community build using the new version and merging this onSuccess?

@adriaanm
Member

Let's just bump it in 2.12.1.

@SethTisue
Member

the 2.12 community build already tracks master of scala-xml, and properly includes it in the Scala used by the rest of the projects, so there's no need to run that specially.

waiting for 2.12.1 is sensible.

@SethTisue
Member

re my comment above, scala-xml-ref no longer exists so my comment no longer applies.

@SethTisue
Member

fyi @biswanaths @ashawley

@ashawley
Contributor

Are there a lot of people who use scala-library-all?

In addition to getting shipped, does incrementing the version change the version used in parts of the compiler system?

@SethTisue
Member
SethTisue commented Oct 24, 2016 edited

Are there a lot of people who use scala-library-all?

I doubt it. Only beginners ought to use it (unless nobody at all should use it, which you could certainly argue), and I don't see beginner resources recommending it, so I bet it's used pretty much never. (That's just off the top of my head though, I haven't tried looking at e.g. Maven download numbers.)

I think we could axe it for 2.13, but it may be that by then something will be happening with the Scala Platform that will change all this around.

In addition to getting shipped, does incrementing the version change the version used in parts of the compiler system

yes

@ashawley
Contributor

Thanks, Seth. Good to know.

Yeah, usage seems pretty low for scala-library-all.

https://mvnrepository.com/artifact/org.scala-lang/scala-library-all

@ashawley
Contributor

I see no reason to rush shipping 1.0.6 in to the 2.12.0 release. I predict people will more likely just use scala-xml package directly, if they really want to use 1.0.6 and the fixes it contains.

@SethTisue
Member

@adriaanm let's merge?

@adriaanm adriaanm merged commit 06b266f into scala:2.12.x Oct 31, 2016

5 checks passed

cla @SethTisue signed the Scala CLA. Thanks!
Details
integrate-ide [3250] SUCCESS. Took 15 s.
Details
validate-main [3656] SUCCESS. Took 76 min.
Details
validate-publish-core [3587] SUCCESS. Took 6 min.
Details
validate-test [3163] SUCCESS. Took 65 min.
Details
@SethTisue SethTisue deleted the SethTisue:scala-xml-1.0.6 branch Nov 1, 2016
@SethTisue
Member

oops, we missed that 1.0.6 hasn't actually been published for 2.12

@SethTisue
Member

oops, we missed that 1.0.6 hasn't actually been published for 2.12

fixed: scala/scala-xml#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment