Fix Greek Mythology references in compiler package #5786
Merged
Conversation
|
(CI failure is real) |
|
Fix this |
janekdb
force-pushed the
janekdb:topic/2.12.x-scaladoc-spelling-corrections-3
branch
from
9318b9d
to
e6a44f1
|
Compile error fixed. Should be plain sailing here on in.
|
| private val runDefintions = currentRun.runDefinitions | ||
| import runDefintions._ | ||
| private val currentRunRunDefinitions = currentRun.runDefinitions | ||
| import currentRunRunDefinitions._ |
Ichoran
Mar 20, 2017
Contributor
Ow. That is not a very friendly name. If you're going to use so many letters, maybe at least explain why this whole thing is necessary val stableRunDefsForImport = currentRun.runDefinitions
Ow. That is not a very friendly name. If you're going to use so many letters, maybe at least explain why this whole thing is necessary val stableRunDefsForImport = currentRun.runDefinitions
SethTisue
Mar 20, 2017
Member
dwijnand
Mar 21, 2017
Member
Ya running and ya running. But ya can't run away from yourself.
Ya running and ya running. But ya can't run away from yourself.
| @@ -1348,7 +1348,7 @@ trait Namers extends MethodSynthesis { | |||
|
|
|||
| // Add a () parameter section if this overrides some method with () parameters | |||
| val vparamSymssOrEmptyParamsFromOverride = | |||
| if (overridden != NoSymbol && vparamSymss.isEmpty && overridden.alternatives.exists(_.info.isInstanceOf[MethodType])) ListOfNil // NOTEL must check `.info.isInstanceOf[MethodType]`, not `.isMethod`! | |||
| if (overridden != NoSymbol && vparamSymss.isEmpty && overridden.alternatives.exists(_.info.isInstanceOf[MethodType])) ListOfNil // NOTE: Must check `.info.isInstanceOf[MethodType]`, not `.isMethod`! | |||
Ichoran
Mar 20, 2017
Contributor
Must should be must as it is a sentence fragment. (If we're going to be really pedantic.)
Must should be must as it is a sentence fragment. (If we're going to be really pedantic.)
janekdb
Mar 21, 2017
Author
Member
Now lowercase matching the majority case,
$ grep -rh -oE '(NOTE:.*)' src/|cut -c1-7|sort|uniq -c
1 NOTE: `
1 NOTE: *
2 NOTE: a
1 NOTE: A
1 NOTE: b
11 NOTE: c
2 NOTE: C
1 NOTE: d
2 NOTE: e
1 NOTE: E
3 NOTE: f
2 NOTE: g
1 NOTE: h
1 NOTE: i
2 NOTE: I
2 NOTE: m
2 NOTE: o
1 NOTE: q
2 NOTE: r
1 NOTE: s
1 NOTE: S
6 NOTE: t
1 NOTE: T
3 NOTE: U
1 NOTE: V
4 NOTE: w
1 NOTE: W
Now lowercase matching the majority case,
$ grep -rh -oE '(NOTE:.*)' src/|cut -c1-7|sort|uniq -c
1 NOTE: `
1 NOTE: *
2 NOTE: a
1 NOTE: A
1 NOTE: b
11 NOTE: c
2 NOTE: C
1 NOTE: d
2 NOTE: e
1 NOTE: E
3 NOTE: f
2 NOTE: g
1 NOTE: h
1 NOTE: i
2 NOTE: I
2 NOTE: m
2 NOTE: o
1 NOTE: q
2 NOTE: r
1 NOTE: s
1 NOTE: S
6 NOTE: t
1 NOTE: T
3 NOTE: U
1 NOTE: V
4 NOTE: w
1 NOTE: W
cb5ffc3
to
22ac970
|
on behalf of the Nicolaas Govert de Bruijn estate, I thank you. |
| @@ -117,13 +117,13 @@ trait TypeDiagnostics { | |||
| */ | |||
| final def exampleTuplePattern(names: List[Name]): String = { | |||
| val arity = names.length | |||
| val varPatterNames: Option[List[String]] = sequence(names map { | |||
| val varPatternNames: Option[List[String]] = sequence(names map { | |||
paplorinc
Apr 4, 2017
Contributor
minor: maybe remove var prefix if it's a val :)
val patternNames
minor: maybe remove var prefix if it's a val :)
val patternNames
janekdb
Apr 4, 2017
Author
Member
In context I think the val is about variables so it's okay to leave as-is,
val varPatterNames: Option[List[String]] = sequence(names map {
case name if nme.isVariableName(name) => Some(name.decode)
case _ => None
})
WDYT?
In context I think the val is about variables so it's okay to leave as-is,
val varPatterNames: Option[List[String]] = sequence(names map {
case name if nme.isVariableName(name) => Some(name.decode)
case _ => None
})
WDYT?
janekdb
force-pushed the
janekdb:topic/2.12.x-scaladoc-spelling-corrections-3
branch
3 times, most recently
from
a286082
to
a23898e
Improve documentation some packages and correct some typos in these directories, - compiler - library
|
Fixed conflicts. |
|
thanks! looking forward to the PR that straightens out the scalac situation w/r/t qabbalism, the medieval era, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Improve documentation in some packages and correct some typos in these directories,