Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial unification unconditional; deprecate -Xexperimental #6309

Merged

Conversation

@milessabin
Copy link
Contributor

@milessabin milessabin commented Feb 3, 2018

Partial unification is now enabled unless -Xsource:2.12 is specified. The -Ypartial-unification flag has been removed and the -Xexperimental option, which is now redundant, has been deprecated.

@milessabin milessabin requested a review from adriaanm Feb 3, 2018
@milessabin milessabin added this to the 2.13.0-M4 milestone Feb 3, 2018
@Daenyth
Copy link

@Daenyth Daenyth commented Feb 3, 2018

Does it make sense to preserve the -Ypartial-unification flag but have it be a no-op, printing a warning, to ease build.sbt transitions?

@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Feb 3, 2018

According to @adriaanm, no, because -Y options were always subject to change without notice. If you can persuade him otherwise I'd be happy to update the PR.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 5, 2018

Maybe there’s another possibility here, of doing something stronger than deprecation, namely refusing to accept the flag, but also printing something more helpful than “huh? -Ypartial-unification`? never heard of it”.

(thinking out loud)

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Feb 14, 2018

Maybe there’s another possibility here, of doing something stronger than deprecation, namely refusing to accept the flag, but also printing something more helpful than “huh? -Ypartial-unification`? never heard of it”.

Sounds like @eed3si9n's "Restligeist macro" idea: https://twitter.com/eed3si9n/status/770584274819055617

We have those in sbt 1 for the old sbt 0.9-0.12 operators: https://github.com/sbt/sbt/blob/v1.1.1/main-settings/src/main/scala/sbt/std/TaskMacro.scala#L129-L130.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 19, 2018

@adriaanm Jenkins seems wedged on this one, won't rebuild

@milessabin try rebasing?

@milessabin milessabin force-pushed the milessabin:topic/unconditional-partial-unification branch from f03ab36 to 54f9a43 Feb 19, 2018
@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Feb 19, 2018

Rebased.

@adriaanm
Copy link
Member

@adriaanm adriaanm commented Feb 20, 2018

The jenkins upgrade appears to have broken the job notification plugin. No idea what's wrong. The start of job notification arrives fine, end of job is logged as sent on the jenkins side, but never arrives at scabot. 🤔

@scala scala deleted a comment from milessabin Feb 21, 2018
@scala scala deleted a comment from milessabin Feb 21, 2018
@scala scala deleted a comment from milessabin Feb 21, 2018
@scala scala deleted a comment from milessabin Feb 21, 2018
@scala scala deleted a comment from milessabin Feb 21, 2018
@scala scala deleted a comment from milessabin Feb 21, 2018
@milessabin milessabin force-pushed the milessabin:topic/unconditional-partial-unification branch from 54f9a43 to a942d33 Mar 5, 2018
@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Mar 5, 2018

Rebased.

@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Mar 9, 2018

Is there any more that needs to be done before this can be merged?

Partial unification is now enabled unless -Xsource:2.12 is specified.
The -Ypartial-unification flag has been removed and the -Xexperimental
option, which is now redundant, has been deprecated.
@milessabin milessabin force-pushed the milessabin:topic/unconditional-partial-unification branch from a942d33 to 7d5e0b0 Mar 22, 2018
@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Mar 22, 2018

Rebased ... also ... bump!

@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Apr 6, 2018

@adriaanm is there anything blocking this from being merged now?

@adriaanm adriaanm merged commit ced7076 into scala:2.13.x Apr 6, 2018
2 checks passed
2 checks passed
@scala-jenkins
cla @milessabin signed the Scala CLA. Thanks!
Details
@scala-jenkins
validate-main [539] SUCCESS. Took 31 min.
Details
@milessabin
Copy link
Contributor Author

@milessabin milessabin commented Apr 6, 2018

Hurrah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants