Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Partial redesign of incremental compiler invalidation. #645

Merged
merged 1 commit into from May 31, 2012

Conversation

Projects
None yet
4 participants
Contributor

odersky commented May 30, 2012

We now do the right thing when packages are either newly created or deleted. Previously there was a problem when a new package was created inside a system package (and, unofrtunately, root is a system package). That's fixed now. We also approximate more tightly now when packages are newly created (iei the newly created symbol gets rescanned, instead of its owner).

Incremental class invalidation: dealing with empty package.

The compiler can now also invalidate the empty package. Previously, no invalidation was done because empty was identified with root, which is considered a system package.

(1) Fixed NPE when creating a new toplevel package in invalidation. (2) generalized interface to deal with multiple entries at a time.

Review by @harrah, @pvlugter, @adriaanm

@odersky odersky Partial redesign of incremental compiler invalidation.
We now do the right thing when packages are either newly created or deleted. Previously there was a problem when a new package was created inside a system package (and, unofrtunately, root is a system package). That's fixed now. We also approximate more tightly now when packages are newly created (iei the newly created symbol gets rescanned, instead of its owner).

Incremental class invalidation: dealing with empty package.

The compiler can now also invalidate the empty package. Previously, no invalidation was done because empty was identified with root, which is considered a system package.

(1) Fixed NPE when creating a new toplevel package in invalidation. (2) generalized interface to deal with multiple entries at a time.
e156d4a
Contributor

pvlugter commented May 31, 2012

+1 Simple tests all work for me

@adriaanm adriaanm added a commit that referenced this pull request May 31, 2012

@adriaanm adriaanm Merge pull request #645 from odersky/topic/inkling-consolidated
Partial redesign of incremental compiler invalidation.
71006c0

@adriaanm adriaanm merged commit 71006c0 into scala:master May 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment