Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove -Xmax-classfile-length; hard-code to 240 #7497
This option allowed users to limit the size of classfile names
However, this means that classfiles made from a compiler with the
So, remove it and default to 240 (the limit in docker).
See also scala/bug#8199
This was referenced
Dec 5, 2018
For our use cases changing the behavior is fine (and I would be happy to have this in 2.12.x) .
In general it breaks binary compatability though doesn't it (e.g. serialisation). It seems that it was already broken and this is stability though so it seems better that we had before
Changing it breaks binary/serialisation compat, yes. This is 2.13 so neither of those are guaranteed anyways. If we did the other (more complicated) solution of pickling flattened names it would allow artifacts produced with one value to be used to compile sources even with a different value; this might be helpful to e.g. the ecryptfs people.
referenced this pull request
Dec 5, 2018
I wonder how common ecryptfs is. Did we ever get reports of people being affected by this? It also seems they removed ecryptfs from ubuntu in 18.04 (https://www.linuxuprising.com/2018/04/how-to-encrypt-home-folder-in-ubuntu.html). Is full-disk encryption affected?
Jan 24, 2019
I took a look at how popular ecryptfs might be, and I conclude we shouldn't worry too much. https://askubuntu.com/questions/1029249/how-to-encrypt-home-on-ubuntu-18-04