New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve refcheck of missing method #7506

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@som-snytt
Copy link
Contributor

som-snytt commented Dec 8, 2018

Improve type comparison and also check whether a member fails to override because of a missing implicit modifier.

Follow-up to scala/bug#9138

Improve refcheck note
Improve refcheck of missing method

Also note if the overriding method has to
declare an implicit parameter list, absent
other failures.

Tweak flatmapping over the advice

Normally the advice is an option: no advice at all,
empty addendum, full advice. Use null for none at all.

@som-snytt som-snytt force-pushed the som-snytt:issue/refchk-message branch from 83212f2 to 3be265c Dec 9, 2018

@som-snytt

This comment has been minimized.

Copy link
Contributor

som-snytt commented Dec 9, 2018

/rebuild

@lrytz

lrytz approved these changes Dec 12, 2018

Copy link
Member

lrytz left a comment

Thanks, looks korrekt

@lrytz lrytz merged commit 47c3199 into scala:2.13.x Dec 12, 2018

3 checks passed

cla @som-snytt signed the Scala CLA. Thanks!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
validate-main [5980] SUCCESS. Took 27 min.
Details

@som-snytt som-snytt deleted the som-snytt:issue/refchk-message branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment