Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Eclipse project files for library, reflect, fjbg & compiler #759

Merged
merged 1 commit into from Jun 26, 2012

Conversation

Projects
None yet
5 participants
Contributor

dragos commented Jun 22, 2012

They are now in src/eclipse/. Removing the old ones from the root.

To use these project files you need to define the Eclipse path variable
SCALA_BASEDIR, in General/Workspace/Linked Resources.

These projects have proper dependencies. The compiler depends on the library project, so you
will need both in the workspace. Any changes in the library will be picked up by the compiler project. Same for asm. The Sbt builder will hopefully be smart enough to recompile only the necessary files.

@jsuereth jsuereth commented on the diff Jun 22, 2012

src/eclipse/scala-library/.project
@@ -15,4 +15,16 @@
<nature>org.scala-ide.sdt.core.scalanature</nature>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
+ <linkedResources>
+ <link>
+ <name>build-quick-lib</name>
+ <type>2</type>
+ <locationURI>SCALA_BASEDIR/build/quick/classes/library</locationURI>
@jsuereth

jsuereth Jun 22, 2012

Member

Do you use ant to drive the builds?

@dragos

dragos Jun 22, 2012

Contributor

Yes, I thought it's still the official way. Good defaults are important, so do you suggest to place it somewhere else?

I like the quick location because then I can use the quick/bin/scalac runner script to immediately test my compiler.

@adriaanm

adriaanm Jun 25, 2012

Owner

that's how i test my eclipse-built compiler as well

@jsuereth jsuereth and 1 other commented on an outdated diff Jun 22, 2012

src/eclipse/scala-compiler/.classpath
<classpathentry kind="lib" path="lib/ant/ant.jar"/>
- <classpathentry kind="output" path="build/quick/classes/compiler"/>
+ <classpathentry kind="lib" path="lib/fjbg.jar"/>
@jsuereth

jsuereth Jun 22, 2012

Member

Note: This is rebuilt in quick. Same for MSIL.

@dragos

dragos Jun 22, 2012

Contributor

Ah, you're right. So fjbg.jar is not retrieved by pull-binary-libs anymore?

@jsuereth

jsuereth Jun 22, 2012

Member

It is, but it's only tied to STARR. The real FJBG source may have changed, and you'll wind up with compiler errors.

We don't need a new starr everytime FJBG source changes now.

@jsuereth jsuereth and 1 other commented on an outdated diff Jun 22, 2012

src/eclipse/scala-compiler/.classpath
@@ -1,12 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
- <classpathentry kind="src" path="src/compiler"/>
+ <classpathentry kind="src" path="compiler"/>
+ <classpathentry combineaccessrules="false" kind="src" path="/scala-library"/>
@jsuereth

jsuereth Jun 22, 2012

Member

Is there one of these for reflect too?

@dragos

dragos Jun 22, 2012

Contributor

I just sent a mail to scala-internals describing my changes. I don't have a project for reflect.

Member

xeno-by commented Jun 22, 2012

Can we have a README about how to use this stuff somewhere?

Contributor

dragos commented Jun 22, 2012

@xeno-by, I sent an email to scala-internals. I'll add the README if I get at least one other person confirming that it works as intended. :)

Member

xeno-by commented Jun 22, 2012

Yeah, sure, I saw the email, just wanted to ask for a README anyways. Thank
you!

On 22 June 2012 16:38, Iulian Dragos <
reply@reply.github.com

wrote:

@xeno-by, I sent an email to scala-internals. I'll add the README if I get
at least one other person confirming that it works as intended. :)


Reply to this email directly or view it on GitHub:
#759 (comment)

@dragos dragos Added new project files for using the compiler and library inside Ecl…
…ipse and removed the old ones.

To use these project files you need to define the Eclipse 'path variable'
SCALA_BASEDIR, in General/Workspace/Linked Resources.
fd6573a
Contributor

dragos commented Jun 26, 2012

I just added a README and projects for reflect and fjbg.

Member

xeno-by commented Jun 26, 2012

<3

Owner

adriaanm commented Jun 26, 2012

that looks like a LGTM to me

@adriaanm adriaanm added a commit that referenced this pull request Jun 26, 2012

@adriaanm adriaanm Merge pull request #759 from dragos/new-eclipse-project-files
Eclipse project files for library, reflect, fjbg & compiler
51de497

@adriaanm adriaanm merged commit 51de497 into scala:master Jun 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment