Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Case class copy and apply inherit access modifiers from constructor [ci: last-only] #7702
IIRC it's to control who can create an instance of a class -- if this is what you want, a private constructor is useless if your apply is public, so basically the same as what your PR offers by default :-)
@adriaanm Err... Not following 100% what you're saying. Some of those tests seem to rely specifically on the generated
But anyway I think this PR is ready for review and discussion on how to proceed (SIP or no SIP, -Xsource flag or no flag, ...).
Status of this PR right now:
I reviewed all failing tests and the bugs they are defending against. In all cases the right thing to do seemed to me turning private constructors into protected. That way