Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringOps#collect methods #8113

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
7 participants
@szeiger
Copy link
Contributor

commented May 31, 2019

Overloaded to produce either a String or an IndexedSeq[B], just like map and flatMap.

This was supported in 2.12 but the method was not overloaded in the new StringOps.

For consideration for 2.13.0-RC4 but not a blocker IMO. The implementation is copied almost verbatim from ArrayOps.

@szeiger szeiger added this to the 2.14.0-M1 milestone May 31, 2019

Add StringOps#collect methods
Overloaded to produce either a `String` or an `IndexedSeq[B]`,
just like `map` and `flatMap`

@adriaanm adriaanm force-pushed the szeiger:wip/stringops-collect branch from 584d69f to f6cc304 Jun 4, 2019

@adriaanm adriaanm modified the milestones: 2.14.0-M1, 2.13.0 Jun 4, 2019

@SethTisue

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

as discussed in team meeting just now, this is :shipit: for 2.13.0 once CI likes it

@SethTisue SethTisue self-assigned this Jun 4, 2019

@lrytz

lrytz approved these changes Jun 4, 2019

@sjrd

sjrd approved these changes Jun 4, 2019

Copy link
Member

left a comment

Good to go for Scala.js 0.6.28 and 1.0.0-M8 (as well as the other PRs at https://github.com/scala/scala/pulls?q=is%3Apr+milestone%3A2.13.0+is%3Aclosed).

@SethTisue

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

the Travis build of the language specification is failing. obviously unrelated; opened scala/scala-dev#630 on it

@SethTisue SethTisue merged commit 43e040f into scala:2.13.x Jun 4, 2019

3 checks passed

cla @szeiger signed the Scala CLA. Thanks!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
validate-main [8744] SUCCESS. Took 36 min.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.