Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 11551. use == instead of equals in BitmapIndexedSetNode #8117

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
8 participants
@xuwei-k
Copy link
Contributor

commented Jun 2, 2019

fix scala/bug#11551

@scala-jenkins scala-jenkins added this to the 2.13.1 milestone Jun 2, 2019

@xuwei-k xuwei-k force-pushed the xuwei-k:fix-11551 branch from 75ceb00 to 5ea2460 Jun 2, 2019

@hrhino

hrhino approved these changes Jun 2, 2019

@NthPortal

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

What I don't understand is why that change fixes anything (and/or why it was broken in the first place). equals works fine for j.l.Integer.

@SethTisue SethTisue modified the milestones: 2.13.1, 2.13.0 Jun 2, 2019

@SethTisue

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

I've tentatively put this on a new 2.13.0 milestone, since it seems like something that could mergeable without a further RC. @adriaanm will make the final call

@dwijnand

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

@NthPortal you need to pick to either use equals and hashCode and ignore collaborative equality/hashing (which is faster but some things are "weird"), or you use == and ## (and pay the performance cost). When you're inconsistent these issues crop up (subjectively, worst of both worlds). Notice the use of ##s in HashSet.

@NthPortal

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2019

oh oops - I didn't notice that one was 1 and one was 1L

@adriaanm

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Let's ship this in 2.13.0. Thank you, @xuwei-k!

@adriaanm adriaanm merged commit 6f02f40 into scala:2.13.x Jun 3, 2019

3 checks passed

cla @xuwei-k signed the Scala CLA. Thanks!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
validate-main [8728] SUCCESS. Took 31 min.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.