Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASTy reader: add support for Scala 3.0.0-M3 #9394

Merged
merged 1 commit into from Dec 23, 2020

Conversation

@bishabosha
Copy link
Member

@bishabosha bishabosha commented Dec 16, 2020

This PR does the minimal thing and substitutes references to scala.Matchable to scala.Any,

there was no need to add an extra test case for Export clauses in tasty - they were already tested.

Also adds test cases for the updates to trait encoding and Value class erasure in Scala 3

fixes scala/bug#12259
fixes scala/bug#12286

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Dec 16, 2020
sjrd
sjrd approved these changes Dec 16, 2020
project/DottySupport.scala Outdated Show resolved Hide resolved
@sjrd
Copy link
Member

@sjrd sjrd commented Dec 16, 2020

Should we ignore the TRANSPARENT flag on traits? Is that new in M3 or was it already in M2? I forgot.

Copy link
Member

@SethTisue SethTisue left a comment

LGTM, but as Seb notes let's wait to merge until M3 is out

@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 16, 2020

Should we ignore the TRANSPARENT flag on traits? Is that new in M3 or was it already in M2? I forgot.

yes, that was a change already made for M2 support

Copy link
Member

@dwijnand dwijnand left a comment

Nice, thank you.

project/DottySupport.scala Outdated Show resolved Hide resolved
@bishabosha bishabosha force-pushed the tasty/support-3.0.0-M3 branch from 17a4adf to bfea40f Dec 17, 2020
@bishabosha bishabosha changed the title Tasty reader: support Scala 3.0.0-M3 Tasty reader: support Scala 3.0.0-M3 [ci: last-only] Dec 17, 2020
@bishabosha bishabosha force-pushed the tasty/support-3.0.0-M3 branch from 0300461 to bfea40f Dec 18, 2020
@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 18, 2020

dropped the commit to change DottySupport.dottyVersion, which is covered by #9395

@dwijnand dwijnand changed the title Tasty reader: support Scala 3.0.0-M3 [ci: last-only] Tasty reader: support Scala 3.0.0-M3 Dec 21, 2020
@lrytz lrytz removed their request for review Dec 21, 2020
@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 21, 2020

I think the Travis error seems unrelated

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Dec 21, 2020

Needs a rebase, the error is about not using sbt-dotty 0.5.

@bishabosha bishabosha force-pushed the tasty/support-3.0.0-M3 branch from bfea40f to e91aa06 Dec 21, 2020
@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 21, 2020

squashed and rebased

@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 21, 2020

now the CI says the build fails to compile due to cyclic reference error

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Dec 22, 2020

Could you rebase? I can't push to the scalacenter org, even if it's a PR branch.

- add changes to TASTy format 26.1
- test compat with cats-effect IOApp.Simple
- substitute scala.Matchable for Any
- test erasure of ValueOf from dotty
@bishabosha bishabosha force-pushed the tasty/support-3.0.0-M3 branch from e91aa06 to 357c2af Dec 22, 2020
@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 22, 2020

rebased

@bishabosha
Copy link
Member Author

@bishabosha bishabosha commented Dec 23, 2020

CI looks good

@dwijnand dwijnand merged commit 1851c5d into scala:2.13.x Dec 23, 2020
3 checks passed
@SethTisue SethTisue changed the title Tasty reader: support Scala 3.0.0-M3 TASTy reader: add support for Scala 3.0.0-M3 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment