Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute isComplete together with typeParams for kind-arity check #9400

Merged
merged 1 commit into from Dec 21, 2020

Conversation

@joroKr21
Copy link
Member

@joroKr21 joroKr21 commented Dec 20, 2020

Being complete is a dynamic property. If we take typeParams before being complete they are unusable. But inbetween we might get completed and suddenly start passing the check. This is why the problem manifests in the second parameter of S.

Fixes scala/bug#12187

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Dec 20, 2020
Being complete is a dynamic property. If we take `typeParams`
before being complete they are unusable. But inbetween we might
get completed and suddenly start passing the check. This is why
the problem manifests in the second parameter of `S`.
@joroKr21 joroKr21 changed the title Initialize type params for kind-arity check Compute isCompleted together with typeParams for kind-arity check Dec 20, 2020
@joroKr21 joroKr21 changed the title Compute isCompleted together with typeParams for kind-arity check Compute isComplete together with typeParams for kind-arity check Dec 20, 2020
@joroKr21 joroKr21 marked this pull request as ready for review Dec 20, 2020
Copy link
Member

@dwijnand dwijnand left a comment

Love it how simple the fix is. Thank you! ❤️

@dwijnand dwijnand merged commit cc06c08 into scala:2.13.x Dec 21, 2020
3 checks passed
@joroKr21 joroKr21 deleted the kind-check branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants