Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new prefixDirect in checkKindBounds0 #9404

Merged
merged 1 commit into from Jan 6, 2021
Merged

Conversation

@joroKr21
Copy link
Member

@joroKr21 joroKr21 commented Dec 21, 2020

Analogous to typeSymbolDirect, we add prefixDirect, because prefix normalizes type aliases. But kind-checking should not normalize type aliases. This was the intention as noted by comments and typeSymbolDirect.

Fixes scala/bug#9337
Closes scala/bug#10186, closes scala/bug#9625 with regression tests (fixed by #9193)

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Dec 21, 2020
@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Dec 21, 2020

/rebuild

Analogous to `typeSymbolDirect`, we add `prefixDirect`,
because `prefix` normalizes type aliases.
But kind-checking should not normalize type aliases.
This was the intention as noted by comments and `typeSymbolDirect`.
@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Dec 21, 2020

/rebuild

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 22, 2020

This change seems quite logical to me, but just in case, I'd like to do a community build run: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/2319/

Copy link
Member

@dwijnand dwijnand left a comment

Clean. LGTM.

@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Jan 5, 2021

Looks like the two projects that failed in the community build don't work on java 11:

  • kamon: missing a dependency on javax.annotation
  • shapeless-java-records: requires the latest and greatest from Java (records and sealed classes)

@som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Jan 5, 2021

What are the parameters for scala 2 changes? "Someone who was unhappy is now happy. No one who was happy is now unhappy." Is it possible to justify any migration pain on Scala 2?

@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Jan 5, 2021

I guess "fixed in dotty" is always a good thing to strive for

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Jan 6, 2021

I assume your question is general, not to be taken as you not being in favour of this or such changes.

Re-fixing issues fixed in Scala 3 ("backporting") as well as fast-tracking other changes present in 3, provided they're not too disruptive, are acceptable.

@dwijnand dwijnand merged commit 362dcb5 into scala:2.13.x Jan 6, 2021
3 checks passed
@joroKr21 joroKr21 deleted the prefix-direct branch Jan 6, 2021
@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 9, 2021

@joroKr21 I'm looking through all of the 2.13.5 merged PRs and trying to decide which ones should be explicitly mentioned in the 2.13.5 release notes. in your opinion, do any of your PRs (such as this one) merit calling out individually?

and/or, it's possible is to give them a collective bullet: assorted fixes to typechecking (#123, #456, #789), that kind of thing; I could include a text like that if you provide one

@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Feb 9, 2021

As far as I can remember most of my fixes for 2.13.5 targeted higher-kinded types but I will go through my merged PRs tomorrow. I'm confident they can be summarised in one entry though.

@joroKr21
Copy link
Member Author

@joroKr21 joroKr21 commented Feb 10, 2021

@SethTisue something like this: "Assorted fixes to typechecking higher-kinded types (that bring the status quo closer to Scala 3): #9400, #9404, #9405, #9414, #9417, #9439." I'm not sure if mentioning Scala 3 makes sense, but what I mean is that those bugs are already fixed in dotty.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 10, 2021

I'll use that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants