Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the upper bound of type skolems to enumerate subtypes #9472

Merged
merged 1 commit into from Feb 3, 2021

Conversation

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Feb 1, 2021

Fixes scala/bug#12277

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Feb 1, 2021
@dwijnand dwijnand force-pushed the patmat-widen-tparam branch from 0733455 to 9cc5cf5 Feb 1, 2021
@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 2, 2021

It's difficult to be certain I'm not missing something, but this seems like exactly the fix I expected once as soon as I understood the bug report, and I can't think of any flaws or counterarguments to doing this.

@lrytz
Copy link
Member

@lrytz lrytz commented Feb 3, 2021

LGMT too

@dwijnand
Copy link
Member Author

@dwijnand dwijnand commented Feb 3, 2021

I'll rebase this on #9473, so I don't rebase that one which is still under review.

@dwijnand dwijnand marked this pull request as draft Feb 3, 2021
@dwijnand dwijnand marked this pull request as ready for review Feb 3, 2021
@dwijnand dwijnand force-pushed the patmat-widen-tparam branch 2 times, most recently from 456ff30 to b94fb2f Feb 3, 2021
@dwijnand dwijnand merged commit f530c16 into scala:2.13.x Feb 3, 2021
3 checks passed
@dwijnand dwijnand deleted the patmat-widen-tparam branch Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants