Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make -target support JVM 13, 14, 15, and 16 #9481

Merged
merged 1 commit into from Feb 3, 2021

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 2, 2021

includes #9480. so we should get that one merged first, then I'll rebase this one rebased

@@ -73,7 +73,7 @@ trait StandardScalaSettings { _: MutableSettings =>
object StandardScalaSettings {
// not final in case some separately compiled client code wanted to depend on updated values
val MinTargetVersion = 8
val MaxTargetVersion = 12 // this one goes to twelve
val MaxTargetVersion = 16
Copy link
Member Author

@SethTisue SethTisue Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Spinal Tap joke is lost this far past 11...

@SethTisue SethTisue marked this pull request as ready for review Feb 2, 2021
@SethTisue
Copy link
Member Author

@SethTisue SethTisue commented Feb 2, 2021

% echo 'class S' >! S.scala
% scalac --scala-pr 9481 -target:jvm-17 S.scala
scalac error: '17' is not a valid choice for '-target'
  scalac -help  gives more information
scalac error: bad option: '-target:jvm-17'
  scalac -help  gives more information
% scalac --scala-pr 9481 -target:jvm-16 S.scala
% javap -verbose S | grep 'major version'
major version: 60

@dwijnand dwijnand merged commit f956b11 into scala:2.13.x Feb 3, 2021
3 checks passed
@SethTisue SethTisue deleted the more-targets branch Feb 3, 2021
@SethTisue SethTisue changed the title make -target support JVM 13, 14, 15, and 16 Make -target support JVM 13, 14, 15, and 16 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants