Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ASM 9.1, for JDK 17 support in the optimizer; also support -target:jvm-17 #9489

Merged
merged 2 commits into from Feb 9, 2021

Conversation

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 9, 2021

fixes scala/bug#12332 on 2.13.x (2.12.x PR is #9488)

as with the 9.0 upgrade, I don't want to wait for the next 2.12.x -> 2.13.x merge to get this tested, especially now that 2.13.5 is approaching even faster than we thought

@scala-jenkins scala-jenkins added this to the 2.13.5 milestone Feb 9, 2021
@SethTisue
Copy link
Member Author

@SethTisue SethTisue commented Feb 9, 2021

I don't think we need to do a separate community build run before merging. the next Scala SHA bump in the community build will test this along with other recent PRs.

@SethTisue SethTisue changed the title upgrade to asm 9.1, for JDK 17 support upgrade to asm 9.1, for JDK 17 support; also support -target:jvm-17 Feb 9, 2021
@SethTisue
Copy link
Member Author

@SethTisue SethTisue commented Feb 9, 2021

Ima go ahead and merge this (Dale is off this week and Lukas is mostly off, and anyway I don't think there's anything that needs review).

@SethTisue SethTisue merged commit 32aef72 into scala:2.13.x Feb 9, 2021
4 checks passed
@SethTisue SethTisue deleted the asm-9.1-2.13 branch Feb 9, 2021
@mkurz
Copy link
Contributor

@mkurz mkurz commented Feb 9, 2021

Thanks!

smarter added a commit to dotty-staging/dotty that referenced this issue Feb 9, 2021
@SethTisue SethTisue changed the title upgrade to asm 9.1, for JDK 17 support; also support -target:jvm-17 Upgrade to ASM 9.1, for JDK 17 support in the optimizer; also support -target:jvm-17 Feb 19, 2021
@SethTisue SethTisue mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants