Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of sbt to 1.9.3 #18322

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Bump version of sbt to 1.9.3 #18322

merged 4 commits into from
Aug 3, 2023

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Aug 1, 2023

This bumps the version of sbt for our own build, the community build, and also the version of zinc used in the bridge.

refs: #18314
refs: sbt/zinc#1226

@ckipp01 ckipp01 force-pushed the zinc193 branch 2 times, most recently from ec4809b to 2215018 Compare August 2, 2023 12:09
@ckipp01 ckipp01 marked this pull request as ready for review August 2, 2023 14:43
@ckipp01 ckipp01 requested a review from adpi2 August 2, 2023 14:43
Copy link
Contributor

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but apart from that it looks good to me.

Both of these are just scripted tests which pull their version
from sbtVersion meaning these files aren't doing anything
@ckipp01 ckipp01 merged commit 2f20e08 into scala:main Aug 3, 2023
17 checks passed
@ckipp01 ckipp01 deleted the zinc193 branch August 3, 2023 06:54
Kordyjan added a commit that referenced this pull request Dec 8, 2023
Backports #18322 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
adpi2 added a commit that referenced this pull request Feb 5, 2024
modeled on #18322

I found that we cannot go to 1.9.8 right now, because the self-hosted
part of our GitHub Actions setup runs afoul of
sbt/sbt#7463, which will supposedly be fixed
in sbt 1.10.0

compiler-interface going just to 1.9.6 is intentional — that's the most
recent published version, as per https://github.com/sbt/zinc/releases/

~(gonna let CI tell me if anything else is needed besides the simple
version number bumping)~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants