Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore position offset in DelegatingReporter #1884

Merged
merged 1 commit into from
Mar 11, 2017
Merged

restore position offset in DelegatingReporter #1884

merged 1 commit into from
Mar 11, 2017

Conversation

MasseGuillaume
Copy link
Contributor

No description provided.

@felixmulder
Copy link
Contributor

IIRC this was intentionally removed so that the output to sbt would be identical to that of dotc. Could you provide some verification of this?

felixmulder
felixmulder suggested changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this a request for changes just to make sure this PR has the correct status, no stress Guillaume.

@MasseGuillaume MasseGuillaume mentioned this pull request Feb 6, 2017
Closed
@odersky
Copy link
Contributor

odersky commented Mar 9, 2017

What's the status here?

@MasseGuillaume
Copy link
Contributor Author

MasseGuillaume commented Mar 11, 2017 •
edited
Loading

@felixmulder

 bin/dotc sbt-bridge/sbt-test/compilerReporter/simple/Source.scala 
-- [E006] Unbound Identifier Error: sbt-bridge/sbt-test/compilerReporter/simple/Source.scala 
9 |  val a = er1
  |          ^^^
  |          not found: er1

longer explanation available when compiling with `-explain`

one error found

sbt dotty-sbt-bridge/scripted compilerReporter/simple
-- [E006] Unbound Identifier Error: /tmp/sbt_e825e0d4/simple/Source.scala ------
[info] 9 |  val a = er1
[info]   |          ^^^
[info]   |          not found: er1)

The output look the same.

@felixmulder felixmulder merged commit b2d3b89 into scala:master Mar 11, 2017
@felixmulder
Copy link
Contributor

I'll take your word for it @MasseGuillaume! (=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmulder felixmulder felixmulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasseGuillaume @felixmulder @odersky