Make more use of Fansi throughout the compiler #24303
Closed
+90
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
Highlighting.scalaand a bunch of ad-hoc color-management logic with Fansi, which does the same thing but in a tidier wayMostly a call-for-call replacement, except we no longer juggle
Console.RESETs like we previously did, and a lot of finicky imperative logic is gone since Fansi already implements itThere's definitely more that can be refactored to use
fansi.Strinstead ofjava.lang.Stringto model colored text, but this is a decent start