allow annotations to annotate themselves #24447
Merged
+27
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
the
needs-minor-release
hamzaremmal
commented
Nov 16, 2025
| else | ||
| newSymbol(ctx.owner, name, flags, completer, privateWithin, coord) | ||
| } | ||
| registerSym(start, sym) |
Member
Author
There was a problem hiding this comment.
We need to register the symbol before we resolve the annotations (2 lines below)
hamzaremmal
commented
Nov 16, 2025
| case name: Name => name == sym.name && tp.symbol == sym | ||
| case _ => tp.symbol == sym | ||
| case _ => this.symbol == sym | ||
| readLater(end, reader => |
Member
Author
There was a problem hiding this comment.
We delay it because reading the type of the annotation tp will fail; we prepare this call before registering the symbol and we cannot do it after.
hamzaremmal
added
release-notes
odersky
approved these changes
Nov 26, 2025
Contributor
odersky
left a comment
odersky
left a comment
There was a problem hiding this comment.
The changes to the unpickler LGTM
hamzaremmal
removed
the
stat:needs decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specific feature was removed when #1212 was solved. The issue was always the unpickler crashing.
In this PR, we actually fix the unpickler and recover the old behaviour. The main reason for this PR is #23770.