-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix spurious unused import warnings when import of export is used in creator application #24563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
779b132 to
c005ba9
Compare
|
At the sbt prompt, the project has a scalac task. For this issue, I wonder why it is typechecked as it is. Ref says about |
|
FTR this was largely vibe coded by claude, but I reviewed the final diff and it seems to make sense |
|
Amazing! I wonder if chatgpt would summarize for me. I think somewhere in the middle might be my suggestion to add an attachment to preserve the original, similar to what happens when an imported name is changed. My WIP tries to not munge the tree. If that approach doesn't work out, then eliminating false positives is OK, even at the cost of introducing false negatives. Is it likely to see imports of both a definition and its export? |
Fixes #24562
Tested manually on release-3.8.0, seems to make the spurious warning go away. Haven't tested on
mainsincebin/scalacseems to be broken but the code looks about the same so hopefully it works as well