Skip to content

Conversation

@hamzaremmal
Copy link
Member

Based on @bracevac remarks here #24434 (comment)

We do not need to add -sourcepath when generating the scaladoc since compiling with -from-tasty (what scaladoc does) will put the TASTy in the classpath. This means that the compiler will be happy and will find the symbols.

Closes #24434
Supersedes #24569, #24510.

Thanks Oliver for taking the time to analyze the issue in depth.

@hamzaremmal
Copy link
Member Author

Note that this is not the cleanest scaladoc, it would require some polishing.
Screenshot 2025-11-28 at 11 43 43

@hamzaremmal hamzaremmal added this to the 3.8.0 milestone Nov 28, 2025
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 28, 2025
Copy link
Contributor

@bracevac bracevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭 of approval

@hamzaremmal hamzaremmal merged commit 3828975 into scala:main Nov 28, 2025
46 checks passed
@hamzaremmal hamzaremmal deleted the scaladoc-stdlib branch November 28, 2025 12:36
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Dec 2, 2025
WojciechMazur added a commit that referenced this pull request Dec 2, 2025
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when building scala-library docs

4 participants