Fix generic signatures to collect type params from all enclosing classes #24621
+38
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `javaSig0` only collected type parameter names from the immediate enclosing class when generating Java generic signatures for methods. However, this isn't enough with nested classes where outer class type parameters could clash with method-level type parameters. Now we iterate all enclosing classes to collect their type parameter names, to avoid name conflicts. Fixes scala#24619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
javaSig0only collected type parameter namesfrom the immediate enclosing class when generating Java generic signatures for methods.
However, this isn't enough with nested classes where outer
class type parameters could clash with method-level type parameters.
Now we iterate all enclosing classes to collect their type
parameter names, to avoid name conflicts.
Fixes #24619
Also, in 4afe938, I refactored
javaSig0to collect class-level type parameter names in aMap[String, Name]. This allowed us to eliminate thetypeParamSigWithNamehelper method. Does this somewhat align with your suggestion in #24567 (comment) ? @hamzaremmal