fix: do not allow @targetName on primary constructor too
#24682
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Dec 6, 2025
| if sym.is(Inline) then | ||
| report.error("constructors cannot be `inline`", ddef) | ||
|
|
||
| if sym.targetName != sym.name then |
Member
Author
There was a problem hiding this comment.
Just for the record: Technically, if the specification says (for #22372) we are not allowed to use @targetName on constructors, then this check (that was already present) doesn't encode that specification since we can always write this example below and it will work:
import scala.annotation.targetName
class Foo @targetName("<init>") ()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24681