Fix #7416: Don't emit signatures of fields of primitive types #7417
Conversation
Don't emit signatures for private fields of primitive type
|
scalac has a very similar fix: scala/scala@e3bee06 |
Duhemm
left a comment
Duhemm
left a comment
There was a problem hiding this comment.
Since Scalac has a similar fix, would it make sense to port their test?
|
|
||
| /** Like value class erasure, but value classes erase to their underlying type erasure */ | ||
| def fullErasure(tp: Type)(implicit ctx: Context): Type = | ||
| valueErasure(tp) match |
There was a problem hiding this comment.
Was there some decision about mixing significant indentation syntax with braces syntax? (this match has no braces)
There was a problem hiding this comment.
I currently use indentation syntax for all code I touch to get a better feeling for it. If we decide not to do indentation, we can rewrite to braces automatically.
The reason not to convert to indentation wholesale is that is would destroy commit history.
|
I don't have time to port the test (we do not have an analogue of GenericSignaturesTest, it seems) but if someone could do it that would be welcome! |
3 participants
Don't emit signatures for private fields of primitive type.
Maybe there's a better fix for this?