Fix #7428: Don't make enum values JavaStatic #7436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It leads to backend crashes if the enum is defined in a class and does not seem to be needed anyway.
Member
|
It's needed for Java interop for enums that extend |
Contributor
Author
That's what I assumed. But then I looked at the enum-java test, which runs fine even if JavaStatic is removed. So I am not sure what goes on here. |
If an enum value is static (i.e. part of a globally reachable object), set the JavaStatic flag at erasure.
anatoliykmetyuk
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It leads to backend crashes if the enum is defined in a class and does
not seem to be needed anyway.