New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally read rocksdb configfile #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But it would be great if we could test this, not sure if that's maybe to complicated, though.
What is the reason for keeping |
@normanrz I did not want to change the default behavior in this PR, for it was created to support global options. Dropping -c would make the config file a hard requirement. We can do that if you think it would be a real benefit, but I would defer it to a separate PR |
@fm3 Ok. Let's defer. But I think it would be great to drop the custom |
@jstriebel I added some tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
new command line option
-r <filepath>
causes a rocksdb options file to be read.The two options
create_if_missing
andcreate_missing_column_families
from the file are ignored and are always set totrue
.We still use (and create) the column families specified by the command line parameter
-c
(rather than constructing them from the config file. We will change that in a future PR)A sample rocks-config.ini looks like this
fixes #18