Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scroll-into-view-if-needed and do not scroll body (#2804) #2805

Merged
merged 2 commits into from Jun 27, 2018

Conversation

@daniel-wer
Copy link
Contributor

commented Jun 26, 2018

The body is no longer scrolled by the scroll-into-view-if-needed directive we're using to scroll comments into view if a node with a comment or a tree with comments is activated. I updated the library in the process and addressed the breaking changes.

Mailable description of changes:

  • Fixed a bug where the comment tab was scrolled into view horizontally if a node with a comment was activated.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create a tracing with many comments. Scale up the view ports so there is a horizontal scroll bar. Activate the comment tab. Activating nodes/trees with a comment should scroll the respective comment/tree into view in the comment tab, the body should not scroll though.

Issues:


  • Ready for review

@daniel-wer daniel-wer self-assigned this Jun 26, 2018

@daniel-wer daniel-wer requested a review from philippotto Jun 26, 2018

@philippotto
Copy link
Member

left a comment

Awesome! Works flawlessly 👍

@daniel-wer daniel-wer merged commit e9449e7 into master Jun 27, 2018

1 check passed

ci/circleci: build_test_deploy Your tests passed on CircleCI!
Details

@daniel-wer daniel-wer deleted the fix-scroll-into-view branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.