Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show success toast after resetting annotation in tasks view #3207

Merged
merged 4 commits into from Sep 13, 2018

Conversation

@philippotto
Copy link
Member

commented Sep 12, 2018

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • reset a task from the tasks page and enjoy the toast

Issues:


@philippotto philippotto self-assigned this Sep 12, 2018

@philippotto philippotto requested a review from daniel-wer Sep 12, 2018

@daniel-wer
Copy link
Contributor

left a comment

Nice :)

const label =
annotation.state === "Finished" || doesAnnotationNotBelongToActiveUser ? (
<span>
<React.Fragment>

This comment has been minimized.

Copy link
@daniel-wer

daniel-wer Sep 13, 2018

Contributor

👍

philippotto added 2 commits Sep 13, 2018

@philippotto philippotto merged commit 42c1890 into master Sep 13, 2018

1 check passed

ci/circleci: build_test_deploy Your tests passed on CircleCI!
Details

@fm3 fm3 deleted the success-toast-after-reset branch Sep 13, 2018

philippotto added a commit that referenced this pull request Sep 13, 2018
philippotto added a commit that referenced this pull request Sep 13, 2018
Revert "Add URLs for dashboard tabs" (#3216)
* Revert "auto remove autogen flow-check files on git checkout (#3208)"

This reverts commit 3e8c6b9.

* Revert "Show success toast after resetting annotation in tasks view (#3207)"

This reverts commit 42c1890.

* Revert "Finished Tasks sorting and UI rework (#3202)"

This reverts commit 2e08469.

* Revert "Add URLs for dashboard tabs (#3183)"

This reverts commit 0e29527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.