Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracing on a scratch dataset annyoing #3500

Merged
merged 5 commits into from Jan 3, 2019

Conversation

@daniel-wer
Copy link
Contributor

commented Nov 28, 2018

Unfortunately it's not that easy to change the whole background of the tracing view due to golden layout. Instead, I've made the header look like a construction banner and show a warning. I'll ask for feedback on whether that is sufficient as well or whether they have another idea :)

I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.

URL of deployed dev instance (used for testing):

Steps to test:

  • Checkout the code and change the isScratch property of your datastore to true in the postgres datastores table. Open a tracing and be annoyed :)

Issues:

scratch


@daniel-wer daniel-wer self-assigned this Nov 28, 2018

@daniel-wer daniel-wer requested a review from philippotto Nov 28, 2018


render() {
const divClassName = classnames({
"zoomstep-warning": this.props.isVolumeTracingDisallowed,

This comment has been minimized.

Copy link
@philippotto

philippotto Nov 29, 2018

Member

This had no effect anyway or why did you remove it?

This comment has been minimized.

Copy link
@daniel-wer

daniel-wer Nov 29, 2018

Author Contributor

I also noticed that the zoomstep-warning for volume tracings no longer worked due to golden layout (red border), which is why I removed it. We're showing an error toast anyways.

Yes, it even screwed up the layout a little bit :/

@daniel-wer daniel-wer changed the title Make tracing on a scratch dataset annyoing [Blocked] Make tracing on a scratch dataset annyoing Dec 17, 2018

@fm3

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

I’d suggest going ahead with this and not waiting for the last feedback. It comes close to the original feature request, definitely closer than having nothing.
One thing: /wKlive is specific to one installation. Right now, they are the only one to request that feature but I’d keep it generic anyway, maybe? Something along the lines of “Datasets on this Datastore are marked as ’scratch’” should probably be enough info for the mhlab people to recognize what they have to do. What do you think?

@daniel-wer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

I adapted the message, would go ahead and merge if someone approves the PR :)

@daniel-wer daniel-wer changed the title [Blocked] Make tracing on a scratch dataset annyoing Make tracing on a scratch dataset annyoing Jan 2, 2019

@philippotto
Copy link
Member

left a comment

👍

@daniel-wer daniel-wer merged commit 3bab9ca into master Jan 3, 2019

1 check passed

ci/circleci: build_test_deploy Your tests passed on CircleCI!
Details

@daniel-wer daniel-wer deleted the annoying-scratch branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.