Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seamless fallback #3801

Merged
merged 29 commits into from Mar 4, 2019

Conversation

@philippotto
Copy link
Member

commented Feb 20, 2019

This PR rewrites the logic for fallback rendering. In short:

  • the shader is now able to render arbitrary zoom steps. the lookupbuffer decodes which where the available bucket is and which zoomstep it has (instead of having a look up buffer for each zoom step)
  • the ortho bucket picker is able to select buckets for multiple zoom steps
  • the arbitrary bucket pickers only select one fallback at the moment. I think this is fine, since poorer quality is barely usable for flight mode tracing.
  • the loading strategy can be selected within the dataset settings.
  • also, forgive me father for I have sinned: I made some style tweaks to the settings sidebar, because I felt a strong urge to do so 馃檲

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I tested both loading strategies while throttling the internet connection to dsl 6000

Issues:

Todo:

  • have lab test it
  • find better fix for flight mode bucket picking inaccuracy
  • write migration to add best-first loadingStrategy as preferred setting for all existing task types

@philippotto philippotto requested a review from daniel-wer Feb 20, 2019

@philippotto philippotto self-assigned this Feb 20, 2019

@philippotto philippotto marked this pull request as ready for review Feb 20, 2019

@daniel-wer
Copy link
Contributor

left a comment

Great PR, thanks for all the effort in improving the code quality and flexibility of the GPU rendering!

I'll have a look at whether it's easy to migrate the existing recommendedConfigurations.
Will test now :)

@daniel-wer
Copy link
Contributor

left a comment

Worked really well during testing for me, I didn't experience any black spots 馃憤

I did notice a lower frame rate during flight mode tracing (compared to orthogonal) - ~15FPS compared to ~30FPS and it felt kinda laggy, but I can't say how that compares to the status quo. Let's see what our testers say :)

philippotto and others added 7 commits Feb 26, 2019

@philippotto philippotto merged commit d6b562c into master Mar 4, 2019

1 check passed

ci/circleci: build_test_deploy Your tests passed on CircleCI!
Details

@normanrz normanrz deleted the seamless-fallback branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.