Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle slow save requests better #4593

Merged
merged 11 commits into from May 11, 2020
Merged

Handle slow save requests better #4593

merged 11 commits into from May 11, 2020

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 5, 2020 •
edited by daniel-wer

  • warn the user when there are unsaved changes older than X seconds (for testing, X is set to 5 seconds; for production, I'd suggest to set it to 2 minutes)
  • send a warning to airbrake when a save request takes longer than 1 minute (set to 5 s for testing)
  • send a a warning to airbrake when there was a conflict state (status code 409)

image

URL of deployed dev instance (used for testing):

Steps to test:

  • modify a tracing and a warning at the save button should appear after 5 seconds. the back-end has a hardcoded sleep which should make the save request extra slow

Issues:

@philippotto philippotto self-assigned this May 5, 2020
@philippotto philippotto mentioned this pull request May 5, 2020
Closed
2 tasks
daniel-wer
daniel-wer reviewed May 5, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is a great improvement. Worked great during testing and looks and feels very smooth :)
I added some questions and suggestions.

.circleci/not-on-master.sh Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/sagas/save_saga.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/sagas/save_saga.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/sagas/save_saga.js Show resolved Hide resolved
frontend/javascripts/oxalis/view/action-bar/save_button.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/action-bar/save_button.js Outdated Show resolved Hide resolved
...acingstore/app/com/scalableminds/webknossos/tracingstore/controllers/TracingController.scala Outdated Show resolved Hide resolved
daniel-wer
daniel-wer approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

@bulldozer-boy bulldozer-boy bot merged commit 07eb519 into master May 11, 2020
@bulldozer-boy bulldozer-boy bot deleted the debug-save-timeout branch May 11, 2020 09:38
@philippotto philippotto mentioned this pull request May 11, 2020
Merged
@philippotto philippotto mentioned this pull request May 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philippotto @daniel-wer @fm3