Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -XX:+UseParallelGC in Java 9 and 10 runtimes #624

Closed
jvican opened this issue Aug 13, 2018 · 2 comments
Closed

Use -XX:+UseParallelGC in Java 9 and 10 runtimes #624

jvican opened this issue Aug 13, 2018 · 2 comments

Comments

@jvican
Copy link
Contributor

@jvican jvican commented Aug 13, 2018

The scripts should have this flag so that throughput (and compilation speed) is not compromised for Java 9 users. See related sbt/sbt#3559.

Java 10 should also get this flag given that the parallel G1 still does around 20% worse than parallel gc.

@jvican jvican added this to the v1.1.0 milestone Aug 13, 2018
@jvican jvican removed this from the v1.1.0 milestone Nov 23, 2018
@jvican jvican added this to the v1.1.1 milestone Nov 23, 2018
@jvican
Copy link
Contributor Author

@jvican jvican commented Dec 21, 2018

This is not pressing because we are right now claiming Java 8 is an installation requirement. Moreover, we are checking this is indeed the case in the brew installation so far. I know this is not enough, so a contribution adding a startup check and warning the user if it's not using Java 8 would be welcome.

Coming back to this ticket, now that we have support for reading jvm options from a .jvmopts file placed in the bloop installation directory, all we need to know to fix this issue is to add -XX:+UseParallelGC to the .jvmopts file in the install.py script.

@jvican jvican removed this from the v1.1.x milestone Dec 21, 2018
@jvican jvican added this to the Backlog milestone Dec 21, 2018
@jvican jvican changed the title Add default -XX:+UseParallelGC in Java 9 and 10 by default in scripts Use -XX:+UseParallelGC in Java 9 and 10 runtimes Apr 23, 2019
@jvican
Copy link
Contributor Author

@jvican jvican commented Sep 28, 2019

Fixed by #1032

@jvican jvican closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant