Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return correct scala binary version in workspace/buildTargets #677

Closed
olafurpg opened this issue Oct 16, 2018 · 0 comments
Closed

Return correct scala binary version in workspace/buildTargets #677

olafurpg opened this issue Oct 16, 2018 · 0 comments
Labels
bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP.

Comments

@olafurpg
Copy link
Contributor 

- obtained
+ expected
      "scalaVersion": "2.12.7",
-          "scalaBinaryVersion": "2.12.7",
+          "scalaBinaryVersion": "2.12",
@jvican jvican added bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP. labels Oct 16, 2018
jvican added a commit that referenced this issue Oct 16, 2018
@jvican
Return the scala binary version via bsp
7a6af5d 
We took the easy route before and returned the normal Scala version in
lieu of the proper Scala binary version.

Fixes #677.
@jvican jvican mentioned this issue Oct 16, 2018
Merged
@jvican jvican changed the title BSP workspace/buildTargets returns incorrect scalaBinaryVersion Return correct scala binary version in workspace/buildTargets Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olafurpg @jvican