Fixes resource loading issue #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two important bugs at once: 1. Bloop would use the same CLI classes directories for projects with different configurations exported from sbt. 2. Bloop would not correctly add resources in the classpath because a mishap in the directory we were adding at the very top of the classpath. In short, we were adding the client-specific directory of the project we were invoking `fullClasspath` of, but we should have just left it as the generic classes directory, like we do in all the downstream dependencies. Fixes #1146 Fixes #1144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two important bugs at once:
different configurations exported from sbt.
mishap in the directory we were adding at the very top of the
classpath. In short, we were adding the client-specific directory of
the project we were invoking
fullClasspathof, but we should havejust left it as the generic classes directory, like we do in all the
downstream dependencies.
Fixes #1146
Fixes #1144