Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala Native to 0.4.0 #1445

Merged
merged 2 commits into from Jan 25, 2021

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jan 22, 2021

  • Drop support for Scala Native 0.3

- Drop support for Scala Native 0.3
@lolgab lolgab marked this pull request as ready for review January 22, 2021 21:27
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though I have a very limited knowledge of native - changes look ok to me though.

@WojciechMazur could take a quick look at the changes if they make sense?

Copy link

@WojciechMazur WojciechMazur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm wondering about limited number of build.Mode options. If this limitations comes from bloop itself then it's probably best possible solution

case LinkerMode.Debug => Mode.debug
case LinkerMode.Release => Mode.release
case LinkerMode.Debug => build.Mode.debug
case LinkerMode.Release => build.Mode.releaseFast

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about build.Mode.releaseFull? It's a bit aspirational and in most cases releaseFast is better, but user probably should still be able to use it.

Copy link
Contributor Author

@lolgab lolgab Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this limitations comes from bloop itself then it's probably best possible solution

Yes, it is shared between Scala.js and Scala Native.
I chose releaseFast because it gives good results without taking forever to link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I guess this is ready to be merged @tgodzik ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I will start working on the release, but most likely it will not happen today - my best estimate is Wednesday.

@tgodzik tgodzik merged commit 5026843 into scalacenter:master Jan 25, 2021
@lolgab lolgab deleted the update-scala-native-0.4.0 branch January 25, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants