Add sbt 0.13 support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the build to reflectively invoke scalafix instead of calling the API directly. This has the following benefits - works for 0.13 and 1.0 - avoids binary compatibility issues with sbt classpath (scalapb, fastparse, ...). We should shade scalafix dependencies but that would make it impossible support running custom rules that are published to Maven Central.
| .withDependencies(List(dep)) | ||
| .withRepositories( | ||
| List( | ||
| Repository.MavenCentral, |
This fixes a resolution error for sbt-scripted when cross-building against 0.13. It seems that sbt plugins should simply be single project builds, I've given up on trying to fight against it.
|
Cross-building finally works for 0.13 and 1.2 💪 Let's see if the release scripts work as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards supporting
scalafixDependencies, adding the ability to run custom rules like scala-collection-compat that are published to Maven Central.This commit refactors the build to reflectively invoke scalafix instead
of calling the API directly. This has the following benefits
fastparse, ...). We should shade scalafix dependencies but that would
make it impossible support running custom rules that are published to
Maven Central.