Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact naming by Dependents and Dependencies allows for ambiguity #353

Open
adamvoss opened this issue Jan 15, 2017 · 2 comments
Open

Artifact naming by Dependents and Dependencies allows for ambiguity #353

adamvoss opened this issue Jan 15, 2017 · 2 comments

Comments

@adamvoss
Copy link
Contributor

@adamvoss adamvoss commented Jan 15, 2017

The depends-on: query (such as accessed via "Artifact Dependencies") takes a parameter of form "$organization/$artifactName". The dependents and dependency boxes on artifact pages also display this form.

This is not consistent with the hierarchy a user sees elsewhere in Scaladex which has the general form "$organization/$project/$artifactName/$version", as the $project level is omitted. The user would need to know the $project to get to Artifact page.

Trying to specify an artifact without knowing the project creates ambiguity. For example, if I query for depends-on:ubirch/core do I mean ubirch/ubirch-avatar-service/core or ubirch/ubirch-avatar-service/core?

Noticed while observing #314

@MasseGuillaume
Copy link
Member

@MasseGuillaume MasseGuillaume commented Jan 15, 2017

Correct we should fully qualify the artifact: $organization/$project/$artifactName

@adamvoss adamvoss changed the title Artifact naming by Dependents and Dependencies allows for ambuguity Artifact naming by Dependents and Dependencies allows for ambiguity Jan 17, 2017
@MasseGuillaume MasseGuillaume added this to Backlog in Tasks Jan 27, 2017
@jvican
Copy link
Member

@jvican jvican commented Mar 2, 2017

@MasseGuillaume I couldn't find the place in scaladex where we are doing this. Would you mind referencing the file where your mentioned fix is required? Thanks!

@MasseGuillaume MasseGuillaume moved this from Backlog to In Progress in Tasks Jun 30, 2017
@MasseGuillaume MasseGuillaume moved this from In Progress to Done in Tasks Jul 3, 2017
@MasseGuillaume MasseGuillaume moved this from Done to In Progress in Tasks Jul 3, 2017
@julienrf julienrf moved this from V3 to Backlog in Tasks Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Tasks
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.