New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination performs too many requests #396

Open
julienrf opened this Issue Mar 1, 2017 · 2 comments

Comments

3 participants
@julienrf
Member

julienrf commented Mar 1, 2017

At this place we compute the number of pages to load. However, X-RangeLimit-Total gives the number of results, not the number of pages. Hence, we perform way too many calls.

Eventually we want to use BintrayClient.fetchPaginatedResource instead, which makes just the required number of calls, not more :)

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Mar 2, 2017

Member

This would probably require to change an API call, which would be quite easy! This would make the website faster on load times, which is important for UX. @julienrf can probably elaborate on this when this ticket is unblocked.

Member

jvican commented Mar 2, 2017

This would probably require to change an API call, which would be quite easy! This would make the website faster on load times, which is important for UX. @julienrf can probably elaborate on this when this ticket is unblocked.

@MasseGuillaume

This comment has been minimized.

Show comment
Hide comment
@MasseGuillaume

MasseGuillaume Mar 2, 2017

Member

@jvican this is when we index not when we load a page.

Member

MasseGuillaume commented Mar 2, 2017

@jvican this is when we index not when we load a page.

@MasseGuillaume MasseGuillaume added this to Backlog in Tasks Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment