New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctx.removeTokens(Seq[Token]) instead of ctx.removeTokens(Tokens) #344

Closed
olafurpg opened this Issue Sep 11, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@olafurpg
Member

olafurpg commented Sep 11, 2017

This should be a source compatible change since Tokens <: Seq[Token]

@olafurpg olafurpg added this to the v0.6.0 milestone Sep 11, 2017

@barambani

This comment has been minimized.

Show comment
Hide comment
@barambani

barambani Oct 18, 2017

Contributor

Hi @olafurpg I'm giving a look at this. Do you think that also

def toks(t: Tree): Tokens

should return a Seq[Token] or changing removeTokens is enough ?

Please see
#399

Contributor

barambani commented Oct 18, 2017

Hi @olafurpg I'm giving a look at this. Do you think that also

def toks(t: Tree): Tokens

should return a Seq[Token] or changing removeTokens is enough ?

Please see
#399

@barambani

This comment has been minimized.

Show comment
Hide comment
@barambani

barambani Oct 19, 2017

Contributor

I got my answer from Travis. I'll fix it. Thanks

Contributor

barambani commented Oct 19, 2017

I got my answer from Travis. I'll fix it. Thanks

@barambani

This comment has been minimized.

Show comment
Hide comment
@barambani

barambani Nov 1, 2017

Contributor

Can this be closed or there are bit s left here ?

Contributor

barambani commented Nov 1, 2017

Can this be closed or there are bit s left here ?

@gabro

This comment has been minimized.

Show comment
Hide comment
@gabro

gabro Nov 1, 2017

Collaborator

Yep :) Thanks!

Collaborator

gabro commented Nov 1, 2017

Yep :) Thanks!

@gabro gabro closed this Nov 1, 2017

@olafurpg olafurpg removed this from the v0.6.0 milestone Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment