New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceSymbols that accepts a Seq #345

Closed
gabro opened this Issue Sep 11, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@gabro
Collaborator

gabro commented Sep 11, 2017

It's fairly common to have a Seq to feed replaceSymbols and : _* is cumbersome to use.

@gabro gabro added the core label Sep 11, 2017

@olafurpg olafurpg modified the milestone: v0.5.1 Sep 12, 2017

@rberenguel

This comment has been minimized.

Show comment
Hide comment
@rberenguel

rberenguel Sep 19, 2017

Member

@gabro @olafurpg I'll give a look, then go for lint rules ;)

Member

rberenguel commented Sep 19, 2017

@gabro @olafurpg I'll give a look, then go for lint rules ;)

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 19, 2017

For Issue #345 Started writing a version with Seq[(String, String)] a…
…nd deferring to (String, String)*, but they are the same after type erasure. Added a couple of fake implicits to differentiate them (that works, sure) but actually just dropping the variadic is equivalent (or seems to, since all tests in `test` are green)

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 19, 2017

Left For Issue #345 Left original variadic argument version, version …
…with Seq includes a dummy implicit to avoid problems with erasure. Added a tip to use `scalafmt` when contributing

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 20, 2017

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 20, 2017

For Issue #345 Started writing a version with Seq[(String, String)] a…
…nd deferring to (String, String)*, but they are the same after type erasure. Added a couple of fake implicits to differentiate them (that works, sure) but actually just dropping the variadic is equivalent (or seems to, since all tests in `test` are green)

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 20, 2017

Left For Issue #345 Left original variadic argument version, version …
…with Seq includes a dummy implicit to avoid problems with erasure. Added a tip to use `scalafmt` when contributing

rberenguel added a commit to rberenguel/scalafix that referenced this issue Sep 20, 2017

@olafurpg olafurpg closed this in ff5ebd3 Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment