New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary ExplicitImplicit semantic rewrite. #14

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@olafurpg
Copy link
Member

olafurpg commented Oct 13, 2016

- Use (super experimental) 2.0 version of scalameta

  • Use (super experimental) 4.0 version of scala.meta paradise
  • SBT plugin injects the 4.0 paradise compiler plugin and compiles with -Dpersist.enable
  • ExplicitImplicit inserts the fully qualified type name, no fancy imports yet
  • Everything is tested, including the SBT plugin interaction!
Add rudimentary ExplicitImplicit semantic rewrite.
- Use (super experimental) 2.0 version of scalameta
- Use (super experimental) 4.0 version of scala.meta paradise
- SBT plugin injects the 4.0 paradise compiler plugin and compiles with -Dpersist.enable
- ExplicitImplicit inserts the fully qualified type name, no fancy imports yet
- Everything is tested, including the SBT plugin interaction!
- Fixed tiny bug in VolatileLazyVal because I couldn't help myself

@olafurpg olafurpg force-pushed the semantic branch from 9f4626f to 2e5de74 Oct 13, 2016

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 1, 2016

Superseded by #22. The approach in this PR had several problems:

  • the scala.meta semantic in its current for is incomplete.
  • the scala.meta semantic api is more ambitious than what scalafix needs.
  • we can move faster with our own custom semantic api.

@olafurpg olafurpg closed this Dec 1, 2016

@olafurpg olafurpg deleted the semantic branch May 25, 2017

stephenjudkins pushed a commit to stephenjudkins/scalafix that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment