New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of jsdom installation is not precise enough #136

Closed
julienrf opened this Issue Jun 30, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@julienrf
Member

julienrf commented Jun 30, 2017

We just check if there is a target/scalajs-bundler-jsdom directory, but we should check for the presence of target/scalajs-bundler-jsdom/node_modules/jsdom.

@julienrf julienrf closed this in #218 Feb 11, 2018

julienrf added a commit that referenced this issue Feb 11, 2018

Merge pull request #218 from exoego/precise-jsdom-detection
Fix #136: Add more precise jsdom detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment